example: added docker local workspace #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
added a commit
that referenced
this pull request
Apr 15, 2022
Summary: PRs like #1025 feel like they deserve a doc: type, but we didn't have one. Furthermore our definitions for correct and fix were stale.
coadler
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
┌──────────────────────────────────────────────────────────────────┐
│ RESOURCE STATUS ACCESS │
├──────────────────────────────────────────────────────────────────┤
│ docker_container.workspace ephemeral │
│ └─ dev (linux, amd64) ⦾ connecting [0s] coder ssh colin │
├──────────────────────────────────────────────────────────────────┤
│ docker_volume.coder_volume ephemeral │
└──────────────────────────────────────────────────────────────────┘
The colin workspace has been created!
colin at coder in ~/Projects/coder/coder/examples/docker-local (task/docker-workspace-example)
$ coder ssh colin
coder@d982a97c7cac:/$
Works great!
|
Could you try rebasing? I think I pushed a fix to allow actions to run for external prs. |
|
@coadler seems like some of the tests are failing because of missing env variables. I guess since its a fork the CI job does not have access to the same env vars as the ones in the main repo, which of course is good. But then it would maybe be helpful to somehow exclude these jobs from forks if possible? |
|
@ntimo this is our first external fork, so we'll be removing those steps from requiring the variables! I'll fix that now. |
greyscaled
added a commit
that referenced
this pull request
Apr 15, 2022
Summary: PRs like #1025 feel like they deserve a doc: type, but we didn't have one. Furthermore our definitions for correct and fix were stale.
|
Should be fixed now in #1048. Apologies for the delay! |
ntimo
changed the title
ntimo
changed the title
kylecarbs
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new example template that can be used with the
coder start --devmode to provision a workspace container on the local machine.