Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test flake for DataDog agent logs #1026

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: Test flake for DataDog agent logs #1026

merged 1 commit into from
Apr 18, 2022

Conversation

kylecarbs
Copy link
Member

Sometimes the DataDog agent would fail to connect and
angrily log using the standard lib logger. This would
fail tests. See:

https://github.com/coder/coder/runs/6038192436?check_suite_focus=true

Sometimes the DataDog agent would fail to connect and
angrily log using the standard lib logger. This would
fail tests. See:

https://github.com/coder/coder/runs/6038192436?check_suite_focus=true
@kylecarbs kylecarbs requested a review from f0ssel April 15, 2022 14:54
@kylecarbs kylecarbs self-assigned this Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1026 (855923a) into main (1c55572) will increase coverage by 9.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   57.35%   67.02%   +9.66%     
==========================================
  Files         256      256              
  Lines       14987    14991       +4     
  Branches      136      136              
==========================================
+ Hits         8596    10047    +1451     
+ Misses       5473     3947    -1526     
- Partials      918      997      +79     
Flag Coverage Δ
unittest-go-macos-latest 53.58% <100.00%> (-0.18%) ⬇️
unittest-go-postgres- 66.63% <100.00%> (?)
unittest-go-ubuntu-latest 56.16% <100.00%> (-0.01%) ⬇️
unittest-go-windows-2022 53.05% <100.00%> (-0.02%) ⬇️
unittest-js 62.97% <ø> (ø)
Impacted Files Coverage Δ
cli/start.go 63.84% <100.00%> (+5.18%) ⬆️
peerbroker/proxy.go 58.13% <0.00%> (-2.91%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
provisionerd/provisionerd.go 80.73% <0.00%> (-1.03%) ⬇️
provisioner/terraform/provision.go 68.54% <0.00%> (+0.43%) ⬆️
coderd/templates.go 62.29% <0.00%> (+1.63%) ⬆️
peer/conn.go 80.20% <0.00%> (+2.28%) ⬆️
coderd/workspaceagents.go 61.60% <0.00%> (+3.12%) ⬆️
peerbroker/listen.go 87.50% <0.00%> (+3.33%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c55572...855923a. Read the comment docs.

@kylecarbs kylecarbs enabled auto-merge (squash) April 15, 2022 15:01
@kylecarbs kylecarbs requested a review from Emyrk April 18, 2022 16:06
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I'll assume debug level is ok since this is just metrics.

@kylecarbs kylecarbs merged commit d98b7ec into main Apr 18, 2022
@kylecarbs kylecarbs deleted the ddlog branch April 18, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants