Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove quotes on GitSSH #1043

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: Remove quotes on GitSSH #1043

merged 1 commit into from
Apr 18, 2022

Conversation

kylecarbs
Copy link
Member

This was a bug @f0ssel found that was breaking gitssh.

@kylecarbs kylecarbs requested a review from f0ssel April 15, 2022 20:00
@kylecarbs kylecarbs self-assigned this Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1043 (dedc077) into main (a13ccee) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   67.48%   67.38%   -0.10%     
==========================================
  Files         259      259              
  Lines       15059    15061       +2     
  Branches      151      152       +1     
==========================================
- Hits        10162    10149      -13     
- Misses       3881     3892      +11     
- Partials     1016     1020       +4     
Flag Coverage Δ
unittest-go-macos-latest 53.47% <100.00%> (-0.18%) ⬇️
unittest-go-postgres- 66.63% <100.00%> (-0.08%) ⬇️
unittest-go-ubuntu-latest 56.19% <100.00%> (+0.02%) ⬆️
unittest-go-windows-2022 52.98% <100.00%> (-0.13%) ⬇️
unittest-js 68.10% <ø> (-0.10%) ⬇️
Impacted Files Coverage Δ
agent/agent.go 64.59% <100.00%> (ø)
site/src/components/Form/index.ts 89.47% <0.00%> (-10.53%) ⬇️
provisionerd/provisionerd.go 80.00% <0.00%> (-1.77%) ⬇️
peer/conn.go 79.44% <0.00%> (-1.53%) ⬇️
coderd/workspaceagents.go 58.48% <0.00%> (-1.34%) ⬇️
coderd/provisionerdaemons.go 63.46% <0.00%> (ø)
coderd/database/queries.sql.go 83.86% <0.00%> (ø)
peer/channel.go 83.81% <0.00%> (+0.57%) ⬆️
peerbroker/listen.go 87.50% <0.00%> (+3.33%) ⬆️
cli/cliui/agent.go 82.45% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13ccee...dedc077. Read the comment docs.

This was a bug @f0ssel found that was breaking gitssh.
@kylecarbs kylecarbs merged commit e5a1c30 into main Apr 18, 2022
@kylecarbs kylecarbs deleted the removegitsshquotes branch April 18, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants