autostart/autostop: move to traditional 5-valued cron string for compatibility #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules, automatically set timezone
Codecov Report
@@ Coverage Diff @@
## main #1049 +/- ##
==========================================
+ Coverage 67.31% 67.45% +0.13%
==========================================
Files 259 259
Lines 15061 15100 +39
Branches 152 152
==========================================
+ Hits 10139 10185 +46
+ Misses 3899 3896 -3
+ Partials 1023 1019 -4
Continue to review full report at Codecov.
|
greyscaled
approved these changes
Apr 18, 2022
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| client, err := createClient(cmd) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| workspace, err := client.WorkspaceByName(cmd.Context(), codersdk.Me, args[0]) | ||
| spec := fmt.Sprintf("CRON_TZ=%s %s %s * * %s", autostartTimezone, autostartMinute, autostartHour, autostartDayOfWeek) |
Comment on lines
+77
to
+80
| tzEnv := os.Getenv("TZ") | ||
| if tzEnv == "" { | ||
| tzEnv = "UTC" | ||
| } |
cli/workspaceautostop.go
Outdated
|
|
||
| cmd.Flags().StringVar(&autostopMinute, "minute", "0", "autostop minute") | ||
| cmd.Flags().StringVar(&autostopHour, "hour", "18", "autostop hour") | ||
| cmd.Flags().StringVar(&autostopDayOfWeek, "dow", "1-5", "autostop hour") |
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringVar(&autostopDayOfWeek, "dow", "1-5", "autostop hour") | |
| cmd.Flags().StringVar(&autostopDayOfWeek, "dow", "1-5", "autostop day(s) of week") |
| at: time.Time{}, | ||
| expectedNext: time.Time{}, | ||
| expectedError: "validate weekly schedule: expected month and dom to be *", | ||
| }, |
|
@johnstcn we're seeing a parse failure in our Storybook. I think we need to update these here to have coder/site/src/test_helpers/entities.ts Lines 64 to 81 in f2904f6 |
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modfies the original 3-valued cron strings used in package
scheduleto be traditional 5-valued cron strings.schedule.Weeklywill validate that themonthanddomfields are equal to*TZenv var, defaulting to UTC--minute,--hour,--dow, and--tzarguments. Default schedules are provided that should suffice for most users.Fixes #993