Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sign MacOS binaries #1060

Merged
merged 1 commit into from
Apr 18, 2022
Merged

feat: Sign MacOS binaries #1060

merged 1 commit into from
Apr 18, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Apr 18, 2022

This fixes virus warnings when launching Coder on darwin.

*This temporarily enabled the release workflow for testing. That will be fixed prior to merge!

@kylecarbs kylecarbs requested a review from coadler April 18, 2022 18:50
@kylecarbs kylecarbs self-assigned this Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1060 (825ca40) into main (3311c2f) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   67.50%   67.38%   -0.12%     
==========================================
  Files         259      256       -3     
  Lines       15061    14976      -85     
  Branches      152      152              
==========================================
- Hits        10167    10092      -75     
+ Misses       3880     3875       -5     
+ Partials     1014     1009       -5     
Flag Coverage Δ
unittest-go-macos-latest 53.63% <ø> (+0.08%) ⬆️
unittest-go-postgres- 66.74% <ø> (+0.02%) ⬆️
unittest-go-ubuntu-latest 56.12% <ø> (-0.01%) ⬇️
unittest-go-windows-2022 ?
unittest-js 67.96% <ø> (-0.14%) ⬇️
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
provisionerd/provisionerd.go 79.26% <0.00%> (-2.50%) ⬇️
codersdk/users.go 64.60% <0.00%> (-1.27%) ⬇️
peer/conn.go 79.18% <0.00%> (-0.77%) ⬇️
coderd/provisionerdaemons.go 62.95% <0.00%> (-0.52%) ⬇️
coderd/database/queries.sql.go 83.37% <0.00%> (-0.49%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3311c2f...825ca40. Read the comment docs.

@kylecarbs kylecarbs force-pushed the signmacos branch 2 times, most recently from 9ba68cf to ad5a0e4 Compare April 18, 2022 19:27
This fixes virus warnings when launching Coder on darwin.
@kylecarbs kylecarbs merged commit 866205c into main Apr 18, 2022
@kylecarbs kylecarbs deleted the signmacos branch April 18, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants