Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable TURN logs #1061

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: Disable TURN logs #1061

merged 1 commit into from
Apr 18, 2022

Conversation

kylecarbs
Copy link
Member

This was accidentally merged as part of the TURN PR. In the future
we can wrap this to provide useful output, but right now it's too
verbose.

This was accidentally merged as part of the TURN PR. In the future
we can wrap this to provide useful output, but right now it's too
verbose.
@kylecarbs kylecarbs self-assigned this Apr 18, 2022
@kylecarbs kylecarbs requested a review from johnstcn April 18, 2022 22:51
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #1061 (8a776f2) into main (d202f20) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1061      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files         260      260              
  Lines       15374    15374              
  Branches      152      152              
==========================================
- Hits        10341    10340       -1     
  Misses       3986     3986              
- Partials     1047     1048       +1     
Flag Coverage Δ
unittest-go-macos-latest 53.84% <100.00%> (+0.01%) ⬆️
unittest-go-postgres- 66.53% <100.00%> (+<0.01%) ⬆️
unittest-go-ubuntu-latest 56.21% <100.00%> (-0.17%) ⬇️
unittest-go-windows-2022 53.28% <100.00%> (-0.01%) ⬇️
unittest-js 67.96% <ø> (ø)
Impacted Files Coverage Δ
coderd/turnconn/turnconn.go 81.91% <100.00%> (ø)
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
coderd/workspaceagents.go 61.11% <0.00%> (-1.49%) ⬇️
peer/conn.go 77.15% <0.00%> (-1.02%) ⬇️
provisionerd/provisionerd.go 80.58% <0.00%> (-0.74%) ⬇️
provisioner/terraform/provision.go 68.54% <0.00%> (+0.43%) ⬆️
coderd/provisionerdaemons.go 60.37% <0.00%> (+0.51%) ⬆️
peer/channel.go 85.54% <0.00%> (+0.57%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
codersdk/provisionerdaemons.go 65.67% <0.00%> (+5.97%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202f20...8a776f2. Read the comment docs.

@kylecarbs
Copy link
Member Author

Going to admin merge because this is actively breaking main, and the diff certainly isn't controversial.

@kylecarbs kylecarbs merged commit 1df943e into main Apr 18, 2022
@kylecarbs kylecarbs deleted the turnlog branch April 18, 2022 23:01
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Might be nice to hide this behind a ENABLE_TURN_DEBUG_LOG env var

@kylecarbs
Copy link
Member Author

Yup. I'm going to improve the logging of all connection things in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants