Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip leaked pion goroutines in peer #108

Merged
merged 3 commits into from
Jan 31, 2022
Merged

test: Skip leaked pion goroutines in peer #108

merged 3 commits into from
Jan 31, 2022

Conversation

kylecarbs
Copy link
Member

These get cleaned up a few milliseconds after exit, but
cannot be hooked in the current pion API.

These get cleaned up a few milliseconds after exit, but
cannot be hooked in the current pion API.
@kylecarbs kylecarbs requested a review from jawnsy January 31, 2022 03:05
@kylecarbs kylecarbs self-assigned this Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #108 (da38e1e) into main (58f3e43) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   72.01%   71.87%   -0.14%     
==========================================
  Files          89       89              
  Lines        3627     3627              
  Branches       55       55              
==========================================
- Hits         2612     2607       -5     
- Misses        795      799       +4     
- Partials      220      221       +1     
Flag Coverage Δ
unittest-go-macos-latest 67.62% <ø> (-0.38%) ⬇️
unittest-go-ubuntu-latest 70.00% <ø> (+0.22%) ⬆️
unittest-go-windows-latest 67.31% <ø> (+0.41%) ⬆️
unittest-js 78.30% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 76.04% <0.00%> (-1.05%) ⬇️
peer/channel.go 84.14% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f3e43...da38e1e. Read the comment docs.

Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kylecarbs kylecarbs merged commit b8cd579 into main Jan 31, 2022
@kylecarbs kylecarbs deleted the peerroutine branch January 31, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants