Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "coder ssh --shuffle" easter egg #1084

Merged
merged 4 commits into from
May 17, 2022
Merged

feat: "coder ssh --shuffle" easter egg #1084

merged 4 commits into from
May 17, 2022

Conversation

dwahler
Copy link
Contributor

@dwahler dwahler commented Apr 19, 2022

Adds a hidden coder ssh --shuffle command that picks a random workspace to connect to.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1084 (36c50c0) into main (f5693df) will decrease coverage by 0.16%.
The diff coverage is 29.54%.

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   66.58%   66.41%   -0.17%     
==========================================
  Files         284      284              
  Lines       18593    18628      +35     
  Branches      235      235              
==========================================
- Hits        12380    12372       -8     
- Misses       4950     4986      +36     
- Partials     1263     1270       +7     
Flag Coverage Δ
unittest-go-macos-latest 53.55% <29.54%> (-0.19%) ⬇️
unittest-go-postgres- 65.10% <29.54%> (-0.05%) ⬇️
unittest-go-ubuntu-latest 55.98% <29.54%> (-0.30%) ⬇️
unittest-go-windows-2022 51.99% <29.54%> (-0.08%) ⬇️
unittest-js 73.67% <ø> (ø)
Impacted Files Coverage Δ
cli/ssh.go 34.28% <29.54%> (-2.15%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
coderd/httpapi/httpapi.go 71.25% <0.00%> (-6.25%) ⬇️
peer/conn.go 77.88% <0.00%> (-4.43%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/channel.go 84.21% <0.00%> (-1.76%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-1.69%) ⬇️
agent/agent.go 65.28% <0.00%> (-0.62%) ⬇️
coderd/provisionerdaemons.go 63.98% <0.00%> (ø)
coderd/database/queries.sql.go 78.32% <0.00%> (+0.17%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5693df...36c50c0. Read the comment docs.

Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the gosec lints, feel free to nolint those though

@deansheather deansheather requested review from kylecarbs and removed request for kylecarbs May 9, 2022 20:39
@misskniss misskniss modified the milestones: V2 Beta, Community MVP May 15, 2022
@misskniss misskniss removed the V2 BETA label May 16, 2022
@greyscaled
Copy link
Contributor

@dwahler are you able to get this one merged?

@dwahler dwahler merged commit 72c2bf8 into main May 17, 2022
@dwahler dwahler deleted the david/easter-egg branch May 17, 2022 22:55
@dwahler
Copy link
Contributor Author

dwahler commented May 17, 2022

Yep, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants