Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples/templates): add GCP VM devcontainer template #11246

Merged
merged 23 commits into from
Dec 21, 2023
Merged

feat(examples/templates): add GCP VM devcontainer template #11246

merged 23 commits into from
Dec 21, 2023
+315 −4

Conversation

matifali
Copy link
Collaborator

@matifali matifali commented Dec 16, 2023 •
edited

Part of #10735

@matifali matifali self-assigned this Dec 16, 2023
bpmct
bpmct approved these changes Dec 20, 2023
View reviewed changes
examples/templates/gcp-devcontainer/main.tf Outdated Show resolved Hide resolved
@matifali
Copy link
Collaborator Author

@ericpaulsen @bpmct FYI, I am also adding both aws-devcontainer and gcp-devcontainer to starter templates.

@matifali matifali enabled auto-merge (squash) December 21, 2023 12:53
@matifali matifali merged commit 5b071f4 into main Dec 21, 2023
24 checks passed
@matifali matifali deleted the gcp-devcontainer-vm branch December 21, 2023 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@ericpaulsen ericpaulsen Awaiting requested review from ericpaulsen

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matifali @bpmct