Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: bump @material-ui/core from 4.9.4 to 4.12.3" #113

Merged

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Jan 31, 2022

Reverts #102

This broke the types on main. test/js wasn't a required check before, so it allowed this dependency to be merged. That's been fixed!

@kylecarbs kylecarbs self-assigned this Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #113 (fa899f6) into main (0f30d85) will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   71.28%   72.12%   +0.84%     
==========================================
  Files          38       89      +51     
  Lines        3120     3627     +507     
  Branches        0       55      +55     
==========================================
+ Hits         2224     2616     +392     
- Misses        691      791     +100     
- Partials      205      220      +15     
Flag Coverage Δ
unittest-go-macos-latest 67.75% <ø> (-0.07%) ⬇️
unittest-go-ubuntu-latest 69.80% <ø> (-0.29%) ⬇️
unittest-go-windows-latest 67.79% <ø> (-0.04%) ⬇️
unittest-js 78.30% <ø> (?)
Impacted Files Coverage Δ
peer/conn.go 77.08% <0.00%> (-2.35%) ⬇️
site/components/Navbar/UserDropdown.tsx 88.00% <0.00%> (ø)
site/components/Table/index.tsx 0.00% <0.00%> (ø)
site/components/Form/FormDropdownField.tsx 91.66% <0.00%> (ø)
site/components/Button/SplitButton.tsx 89.47% <0.00%> (ø)
site/components/Table/TableTitle.tsx 84.61% <0.00%> (ø)
site/test_helpers/mocks.ts 100.00% <0.00%> (ø)
site/components/Form/index.ts 100.00% <0.00%> (ø)
site/components/Icons/WorkspacesIcon.tsx 100.00% <0.00%> (ø)
site/components/Form/FormTitle.tsx 87.50% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f30d85...fa899f6. Read the comment docs.

@kylecarbs kylecarbs requested a review from jawnsy January 31, 2022 15:20
@jawnsy
Copy link
Contributor

jawnsy commented Jan 31, 2022

That's why I'm not a fan of auto merge 😜

@kylecarbs
Copy link
Member Author

Hahahah reasonable. I am for a sturdy CI, and I'm pushing hard to make this one!

@kylecarbs kylecarbs merged commit e798173 into main Jan 31, 2022
@kylecarbs kylecarbs deleted the revert-102-dependabot/npm_and_yarn/material-ui/core-4.12.3 branch January 31, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants