Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cancel concurrent builds with native feature #116

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Feb 1, 2022

Use the native 'concurrency' configuration feature to cancel
concurrent builds, rather than the cancel-workflow-action.
This also allows us to reduce permissions for the workflow.

Use the native 'concurrency' configuration feature to cancel
concurrent builds, rather than the cancel-workflow-action.
This also allows us to reduce permissions for the workflow.
@jawnsy jawnsy self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #116 (f77eeda) into main (7cf686c) will increase coverage by 3.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   68.92%   71.93%   +3.00%     
==========================================
  Files          86       91       +5     
  Lines        3447     3670     +223     
  Branches       59       59              
==========================================
+ Hits         2376     2640     +264     
+ Misses        883      813      -70     
- Partials      188      217      +29     
Flag Coverage Δ
unittest-go-macos-latest 68.13% <ø> (+0.31%) ⬆️
unittest-go-ubuntu-latest 69.80% <ø> (?)
unittest-go-windows-latest 67.38% <ø> (?)
unittest-js 74.72% <ø> (ø)
Impacted Files Coverage Δ
coderd/userpassword/userpassword.go 63.41% <0.00%> (ø)
provisioner/terraform/parse.go 75.00% <0.00%> (ø)
provisioner/terraform/provision.go 57.62% <0.00%> (ø)
database/postgres/postgres.go 70.00% <0.00%> (ø)
provisioner/terraform/serve.go 66.66% <0.00%> (ø)
peer/channel.go 87.19% <0.00%> (+2.43%) ⬆️
peer/conn.go 79.68% <0.00%> (+3.90%) ⬆️
coderd/coderdtest/coderdtest.go 100.00% <0.00%> (+22.64%) ⬆️
database/migrate.go 52.38% <0.00%> (+52.38%) ⬆️
database/pubsub.go 77.08% <0.00%> (+77.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cf686c...f77eeda. Read the comment docs.

@jawnsy jawnsy marked this pull request as ready for review February 1, 2022 00:11
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato!

@@ -26,6 +26,12 @@ permissions:
security-events: none
statuses: none

# Cancel in-progress runs for pull requests when developers push
# additional changes
concurrency:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawnsy jawnsy merged commit 515e55d into main Feb 1, 2022
@jawnsy jawnsy deleted the jawnsy/cancel-concurrent-workflows branch February 1, 2022 00:13
@jawnsy jawnsy removed their assignment Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants