-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cancel concurrent builds with native feature #116
Conversation
Use the native 'concurrency' configuration feature to cancel concurrent builds, rather than the cancel-workflow-action. This also allows us to reduce permissions for the workflow.
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 68.92% 71.93% +3.00%
==========================================
Files 86 91 +5
Lines 3447 3670 +223
Branches 59 59
==========================================
+ Hits 2376 2640 +264
+ Misses 883 813 -70
- Partials 188 217 +29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neato!
@@ -26,6 +26,12 @@ permissions: | |||
security-events: none | |||
statuses: none | |||
|
|||
# Cancel in-progress runs for pull requests when developers push | |||
# additional changes | |||
concurrency: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the native 'concurrency' configuration feature to cancel
concurrent builds, rather than the cancel-workflow-action.
This also allows us to reduce permissions for the workflow.