Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cancel button on create-workspace page wasn't redirecting correctly #117

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

bryphe-coder
Copy link
Contributor

Issue:

Pressing cancel on the create-workspace page would give an unexpected result:

2022-01-31 17 42 13

Defect:

Originally, the project variable was being used for the project name - but then got refactored to keep the actual project data. However, the cancel button logic wasn't updated to take this into account - pushing an incorrect URL.

Fix:

Use the projectName variable, which we already extract for the router

@bryphe-coder bryphe-coder self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #117 (02998f1) into main (515e55d) will increase coverage by 2.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   68.90%   71.63%   +2.73%     
==========================================
  Files          86       91       +5     
  Lines        3447     3670     +223     
  Branches       59       59              
==========================================
+ Hits         2375     2629     +254     
+ Misses        884      823      -61     
- Partials      188      218      +30     
Flag Coverage Δ
unittest-go-macos-latest 67.96% <ø> (+0.17%) ⬆️
unittest-go-ubuntu-latest 69.77% <ø> (?)
unittest-go-windows-latest 67.44% <ø> (?)
unittest-js 74.72% <0.00%> (ø)
Impacted Files Coverage Δ
...pages/projects/[organization]/[project]/create.tsx 0.00% <0.00%> (ø)
provisioner/terraform/parse.go 75.00% <0.00%> (ø)
provisioner/terraform/serve.go 66.66% <0.00%> (ø)
coderd/userpassword/userpassword.go 63.41% <0.00%> (ø)
database/postgres/postgres.go 70.00% <0.00%> (ø)
provisioner/terraform/provision.go 57.62% <0.00%> (ø)
peer/channel.go 84.75% <0.00%> (+0.60%) ⬆️
peer/conn.go 77.86% <0.00%> (+2.08%) ⬆️
coderd/coderdtest/coderdtest.go 100.00% <0.00%> (+22.64%) ⬆️
database/migrate.go 52.38% <0.00%> (+52.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515e55d...02998f1. Read the comment docs.

@bryphe-coder bryphe-coder merged commit bf90ded into main Feb 1, 2022
@bryphe-coder bryphe-coder deleted the bryphe/fix/projects-cancel-redirect branch February 1, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants