feat!: update terraform to version 1.6.x, relax max version constraint

[johnstcn]

Relates to #12009

• Updates default Terraform version to 1.6.6
• Relaxes maximum version constraint on installed Terraform version

This should allow both us and others to experiment more easily with newer versions of Terraform.

Marking this as a breaking change so that it's called out prominently in the release notes.

[deansheather]

We're OK with this from a legal standpoint?

[johnstcn]

We're OK with this from a legal standpoint?

I'm assuming so based on @bpmct 's wording here but good to super confirm.

[coadler]

Yeah we're good

[mtojek]

I'm fine with this change, although it would be great to get 👍 from leadership on the legal side too.

[matifali]

Why not go to 1.7.x?

[johnstcn]

Why not go to 1.7.x?

Our current default is 1.4.6, and going to 1.6.6 is already a big jump.
I'd honestly be happier jumping to 1.5.7 but that's already out of support.

[coadler]

Yeah, I think jumping to 1.6.x first is the play here

[johnstcn]

I'm going to hold off on merging this until @bpmct gives the green light. I'd feel most comfortable doing this right after the next release so that we have a good deal of time to iron out any issues we run into on dogfood.

[matifali]

I am personally using 1.7.x on one of my deployments (coder Deb package and tarraform installed manually) and so far no issues. But I agree we should do it after the release.

[matifali]

@johnstcn I have terraform 1.7.2 and Coder seems to work even though it's outside of the max version. Shouldn't the builds fail in this case?

[johnstcn]

@johnstcn I have terraform 1.7.2 and Coder seems to work even though it's outside of the max version. Shouldn't the builds fail in this case?

It should download the 'known good' Terraform version in this case. You can check the build logs of a workspace for the Terraform version string.

[bpmct]

LGTM! Approved