Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/server): do not redirect /healthz #12080

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 9, 2024

If you set --redirect-access-url=true, then you would have seen these warnings from Kubelet:

   Warning  ProbeWarning  5m52s (x121 over 25m)  kubelet            Liveness probe warning: Probe terminated redirects, Response body: <a href="https://dev.coder.com">Temporary Redirect</a>.                                             │
│   Warning  ProbeWarning  52s (x152 over 26m)    kubelet            Readiness probe warning: Probe terminated redirects, Response body: <a href="https://dev.coder.com">Temporary Redirect</a>.   

We have specific checks for /derp to not redirect in this case, so extending this for /healthz.

@johnstcn johnstcn self-assigned this Feb 9, 2024
@johnstcn johnstcn requested a review from mtojek February 9, 2024 12:44
@johnstcn johnstcn merged commit 2b307c7 into main Feb 9, 2024
24 checks passed
@johnstcn johnstcn deleted the cj/no-redirect-healthz branch February 9, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants