feat: Update generated schema for provisionerd #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
force-pushed
the
provisionerschema
branch
from
d3a4eb8
to
39ff6c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 71.90% 72.24% +0.34%
==========================================
Files 91 91
Lines 3670 3751 +81
Branches 59 59
==========================================
+ Hits 2639 2710 +71
- Misses 814 824 +10
Partials 217 217
Continue to review full report at Codecov.
|
kylecarbs
force-pushed
the
provisionerschema
branch
from
39ff6c7
to
4f8309e
Compare
These changes were part of a bulk change to create provisionerd. They were ripped out for simpler reviewing.
kylecarbs
force-pushed
the
provisionerschema
branch
from
4f8309e
to
b37edc2
Compare
bryphe-coder
reviewed
Feb 1, 2022
| defer reader.Close() | ||
| defer writer.Close() | ||
| go func() { | ||
| decoder := json.NewDecoder(reader) |
There was a problem hiding this comment.
Looks like we're getting really close to being able to stream the terraform logs 🎉
bryphe-coder
reviewed
Feb 1, 2022
| @@ -22,14 +23,16 @@ CREATE TABLE workspace_history ( | |||
| completed_at timestamptz, | |||
| workspace_id uuid NOT NULL REFERENCES workspace (id) ON DELETE CASCADE, | |||
| project_history_id uuid NOT NULL REFERENCES project_history (id) ON DELETE CASCADE, | |||
| name varchar(64) NOT NULL, | |||
| before_id uuid, | |||
| after_id uuid, | |||
| transition workspace_transition NOT NULL, | |||
| initiator varchar(255) NOT NULL, | |||
There was a problem hiding this comment.
Unrelated to this PR, but it reminded me - what are values for initiator like? Is it supposed to reference the user that initiated the transition, or something else?
bryphe-coder
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were part of a bulk change to create provisionerd.
They were ripped out for simpler reviewing.