Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore static credentials for develop.sh #1212

Merged
merged 1 commit into from Apr 28, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Apr 28, 2022

This PR restores static credentials for coder server --dev when run via develop.sh.

@mafredri mafredri self-assigned this Apr 28, 2022
@mafredri mafredri requested a review from presleyp April 28, 2022 17:24
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@presleyp
Copy link
Contributor

@BrunoQuaresma @vapurrmaid @code-asher speak up if you disagree with this approach! Just thought it would be simpler than making sure we've exported, or copy pasting new passwords on each run.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1212 (3d74b91) into main (e330dc1) will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   64.83%   65.36%   +0.53%     
==========================================
  Files         259      265       +6     
  Lines       16716    16937     +221     
  Branches      157      157              
==========================================
+ Hits        10837    11071     +234     
+ Misses       4707     4704       -3     
+ Partials     1172     1162      -10     
Flag Coverage Δ
unittest-go-macos-latest 52.90% <ø> (?)
unittest-go-postgres- 64.60% <ø> (-0.08%) ⬇️
unittest-go-ubuntu-latest 55.32% <ø> (?)
unittest-go-windows-2022 52.48% <ø> (?)
unittest-js 66.50% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
coderd/workspaceagents.go 55.59% <0.00%> (-1.28%) ⬇️
coderd/provisionerdaemons.go 62.28% <0.00%> (-1.02%) ⬇️
cli/ssh_windows.go 0.00% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
cli/cliui/cliui_darwin.go 0.00% <0.00%> (ø)
pty/pty_windows.go 70.14% <0.00%> (ø)
agent/usershell/usershell_darwin.go 100.00% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
coderd/users.go 61.27% <0.00%> (+0.51%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e330dc1...3d74b91. Read the comment docs.

@mafredri mafredri merged commit 4efde58 into main Apr 28, 2022
@mafredri mafredri deleted the mafredri/restore-develop-sh-password-behavior branch April 28, 2022 18:47
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants