fix(tailnet): enforce valid agent and client addresses #12197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
coadler
force-pushed
the
colin/fixtailnetenforcevalidagentandclientaddresses
branch
from
48d488b
to
2491fa5
Compare
coadler
force-pushed
the
colin/fixtailnetenforcevalidagentandclientaddresses
branch
from
2491fa5
to
865dbfc
Compare
spikecurtis
reviewed
Feb 29, 2024
tailnet/tunnel.go
Outdated
|
|
||
| type TunnelAuth interface { | ||
| Authorize(dst uuid.UUID) bool | ||
| AuthorizeIP(src uuid.UUID, ip netip.Prefix) bool |
There was a problem hiding this comment.
Probably should rename this from TunnelAuth because it now covers more than tunnels. CoordReqAuth? Doesn't roll off the tongue...
There was a problem hiding this comment.
In fact, maybe we should refactor this to authorize the *proto.CoordinateRequest instead of having multiple methods --- will make it easier to do other kinds of authorization in future
There was a problem hiding this comment.
yeah, i actually like that a lot better
coadler
force-pushed
the
colin/fixtailnetenforcevalidagentandclientaddresses
branch
from
5c402f4
to
d472478
Compare
spikecurtis
approved these changes
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for
TunnelAuthto also authorize incoming wireguard node IPs, preventing agents from reporting anything other than their static IP generated from the agent ID.