fix: display tooltip when selection is disabled #12439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
changed the title
|
I don't know if a tooltip is a good option here since it is a popover on top of the other 2 popovers. Ports popover -> Sharing level menu -> Toopltip. The menu items can accept any React elements so I think the content in the tooltip could be an item description like the email in the image below: 
Wdyt? |
BrunoQuaresma
approved these changes
Mar 7, 2024
|
I do like your suggestion, but I think we can leave it for when we take another look at this design, and we can live with the tooltip for now. Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot is missing mouse but this is on hover.