feat(agent): expose HTTP debug server over tailnet API #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 13, 2024
mtojek
reviewed
Mar 14, 2024
| @@ -36,6 +36,8 @@ func (a *agent) apiHandler() http.Handler { | |||
| cacheDuration: cacheDuration, | |||
| } | |||
| r.Get("/api/v0/listening-ports", lp.handler) | |||
| r.Get("/debug/magicsock", a.HandleHTTPDebugMagicsock) | |||
| r.Get("/debug/magicsock/debug-logging/{state}", a.HandleHTTPMagicsockDebugLoggingState) | |||
There was a problem hiding this comment.
nit: /debug/magicsock/debug... sounds weird. Maybe POST /debug/magicsock/enable-logger instead?
There was a problem hiding this comment.
I'd rather keep this the same for consistency purposes
agent/agent.go
Outdated
| func (a *agent) HandleHTTPDebugMagicsock(w http.ResponseWriter, r *http.Request) { | ||
| network, ok := a.requireNetwork() | ||
| if !ok { | ||
| w.WriteHeader(http.StatusNotFound) |
There was a problem hiding this comment.
shouldn't that be a different HTTP status? 503?
There was a problem hiding this comment.
You could make the arguemnt yeah, but I didn't see a huge need to change it in this PR. Since it's a debug endpoint though, it's probably fine to change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12161
Exposes the agent magicsock handler over tailnet so you can just dial it over an agent conn.