Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use "make build" on deploy #1261

Merged
merged 1 commit into from May 2, 2022
Merged

fix: Use "make build" on deploy #1261

merged 1 commit into from May 2, 2022

Conversation

kylecarbs
Copy link
Member

This was a missed item in #1259.

@kylecarbs kylecarbs requested a review from coadler May 2, 2022 18:32
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1261 (98c492f) into main (dacc025) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
+ Coverage   66.09%   66.14%   +0.04%     
==========================================
  Files         275      275              
  Lines       17952    17952              
  Branches      216      216              
==========================================
+ Hits        11866    11874       +8     
+ Misses       4851     4845       -6     
+ Partials     1235     1233       -2     
Flag Coverage Δ
unittest-go-macos-latest 53.43% <ø> (+0.06%) ⬆️
unittest-go-postgres- 65.02% <ø> (-0.03%) ⬇️
unittest-go-ubuntu-latest 55.78% <ø> (-0.06%) ⬇️
unittest-go-windows-2022 51.71% <ø> (+0.11%) ⬆️
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 65.90% <0.00%> (-1.24%) ⬇️
coderd/provisionerdaemons.go 63.48% <0.00%> (+0.50%) ⬆️
provisionerd/provisionerd.go 76.70% <0.00%> (+0.53%) ⬆️
peer/conn.go 79.60% <0.00%> (+0.99%) ⬆️
peer/channel.go 86.12% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacc025...98c492f. Read the comment docs.

This was a missed item in #1259.
@kylecarbs kylecarbs merged commit e4e6025 into main May 2, 2022
@kylecarbs kylecarbs deleted the fixdeploy branch May 2, 2022 19:04
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants