feat(coderd): export metric indicating each experiment's status #12657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
changed the title
mtojek
reviewed
Mar 19, 2024
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
mafredri
approved these changes
Mar 19, 2024
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Signed-off-by: Danny Kopping <danny@coder.com>
mafredri
approved these changes
Mar 19, 2024
| var active codersdk.Experiments | ||
| for _, exp := range options.DeploymentValues.Experiments.Value() { | ||
| active = append(active, codersdk.Experiment(exp)) | ||
| } |
There was a problem hiding this comment.
This is fine, but optionally to keep it cleaner, you could move this to codersdk, something like codersdk.ExperimentsFromString(Value()...).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12070
Exposes a metric indicating which experiments are active/inactive.
I chose to expose the experiments that are not active as well because this will allow operators to get the same view in metrics as what we expose in the frontend.