feat(cli/support): confirm before creating bundle #12684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Mar 21, 2024
This reverts commit d44e85b.
mtojek
reviewed
Mar 21, 2024
cli/support.go
Outdated
Comment on lines
82
to
84
| cliLog.Info(inv.Context(), "user confirmed manually", slog.F("answer", ans)) | ||
| } else { | ||
| cliLog.Info(inv.Context(), "user auto-confirmed") |
There was a problem hiding this comment.
Yeah fair, we don't want unnecessary output.
| } | ||
|
|
||
| // Check if we're running inside a workspace | ||
| if val, found := os.LookupEnv("CODER"); found && val == "true" { |
There was a problem hiding this comment.
nit: maybe create a util function for this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last must-haves of #12163
Forces user to confirm before creating a support bundle.
Also adds contextual information to the bundle under
cli_logs.txt.Finally, un-hides theEDIT: will un-hide closer to release.supportcommand`.