Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coderd): add timeout to websocket waitgroup on shutdown #12754

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(coderd): add timeout to websocket waitgroup on shutdown #12754

merged 1 commit into from
Mar 26, 2024

Conversation

coadler
Copy link
Member

@coadler coadler commented Mar 25, 2024 •
edited

Fixes #12494

@coadler Graphite App
Copy link
Member Author

coadler commented Mar 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @coadler and the rest of your teammates on Graphite Graphite

@coadler coadler closed this Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
@coadler coadler reopened this Mar 25, 2024
@coadler coadler marked this pull request as ready for review March 25, 2024 21:04
@coadler coadler enabled auto-merge (squash) March 26, 2024 03:00
@coadler coadler merged commit 5f28220 into main Mar 26, 2024
42 of 51 checks passed
@coadler coadler deleted the colin/fix_coderd_add_timeout_to_websocket_waitgroup_on_shutdown branch March 26, 2024 03:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shutdown gets hung permanently on waiting for websockets
2 participants
@coadler @kylecarbs