Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(site): add e2e to test add and remove user #12851

Merged
merged 13 commits into from
Apr 4, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to #12506

@BrunoQuaresma BrunoQuaresma requested a review from a team April 2, 2024 18:22
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 2, 2024
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team April 2, 2024 18:22
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
@BrunoQuaresma
Copy link
Collaborator Author

@mtojek I think it is way better now, thx for the feedback.

site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
site/e2e/tests/manageUsers.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like to get a final answer for #12851 (comment).

@BrunoQuaresma BrunoQuaresma merged commit 41b8ff3 into main Apr 4, 2024
24 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/e2e-test-users-and-groups branch April 4, 2024 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants