Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(site): add e2e tests for groups #12866

Merged
merged 11 commits into from
Apr 5, 2024
Merged

chore(site): add e2e tests for groups #12866

merged 11 commits into from
Apr 5, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Closes #12506

@BrunoQuaresma BrunoQuaresma requested review from dannykopping, mtojek and a team April 4, 2024 14:59
@BrunoQuaresma BrunoQuaresma self-assigned this Apr 4, 2024
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team April 4, 2024 14:59
code-asher
code-asher approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

One note, the linked issues mentions testing the everyone group which I am not seeing in here, does that need to be added?

@code-asher
Copy link
Member

One other note actually, since this also includes a bug fix should this be prefixed with fix? Too bad we can only squash and merge otherwise you could merge two commits, a chore and a fix.

@BrunoQuaresma
Copy link
Collaborator Author

One note, the linked issues mentions testing the everyone group which I am not seeing in here, does that need to be added?

Good catch, I will add the everyone group test.

One other note actually, since this also includes a bug fix should this be prefixed with fix? Too bad we can only squash and merge otherwise you could merge two commits, a chore and a fix.

That is true, since most of this PR is chore related, I think we should keep it

@BrunoQuaresma BrunoQuaresma merged commit 3fbcdb0 into main Apr 5, 2024
24 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/add-e2e-for-create-and-remove-groups branch April 5, 2024 00:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@code-asher
Copy link
Member

code-asher commented Apr 5, 2024 •
edited

That is true, since most of this PR is chore related, I think we should keep it

True, just worried it will be missed in the changelog for anyone tracking the bug. For users the fix is important, the chore may just be glossed over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e: User/Group management
2 participants
@BrunoQuaresma @code-asher