Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix race in assertWorkspaceLastUsedAtUpdated #12899

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Apr 8, 2024

fixes #12789

Stats are collected asynchronously with respect to sessions ending. Flush repeatedly so that we pick up the collection if we missed it.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review April 8, 2024 11:58
@spikecurtis spikecurtis merged commit 3b7380f into main Apr 8, 2024
27 checks passed
@spikecurtis spikecurtis deleted the spike/12789-flush-repeatedly branch April 8, 2024 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake: TestWorkspaceProxyWorkspaceApps_BlockDirect/ReconnectingPTY/SignedTokenQueryParameter
2 participants