feat: Add history middleware parameters #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be used for streaming logs, checking status, and other operations related to workspace and project history.
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 70.31% 70.61% +0.30%
==========================================
Files 96 98 +2
Lines 4254 4322 +68
Branches 68 68
==========================================
+ Hits 2991 3052 +61
- Misses 1018 1024 +6
- Partials 245 246 +1
Continue to review full report at Codecov.
|
bryphe-coder
reviewed
Feb 1, 2022
Comment on lines
+21
to
+22
| if !ok { | ||
| panic("developer error: project history param middleware not provided") |
There was a problem hiding this comment.
I like that we catch this sort of error right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be used for streaming logs, checking status,
and other operations related to workspace and project
history.