Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: label template settings that require an enterprise license appropriately #12952

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Apr 12, 2024

"Require Active Version" is an enterprise feature, that we currently just show as if it's usable, and then ignore on the backend, leading to a frustrating experience when you feel like you just can't enable this feature, seemingly because of a bug.

@aslilac
Copy link
Member Author

aslilac commented Apr 12, 2024

since I'll be out next week, feel free to just merge this if you don't have any requested changes :)

Copy link
Contributor

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I do think that we have enough enabled properties in the UI that it's starting to make sense to consolidate them into a single object, but that's outside the scope of this PR

I'll go ahead and merge this for you

@Parkreiner Parkreiner merged commit 7cf8577 into main Apr 15, 2024
29 checks passed
@Parkreiner Parkreiner deleted the enterprise-template-settings branch April 15, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants