feat: add warning about use of old/removed/invalid experiments

[dannykopping]

Fixes #12725

If one of the FE folks could help me refactor site/src/pages/DeploySettingsPage/Option.tsx and site/src/pages/DeploySettingsPage/optionValue.ts to allow another boolean indicating whether an experiment is invalid or not, we could change the display of enabled experiments to indicate invalid ones as well. I tried various attempts at this but my lack of TS knowledge is hindering me.

I changed the CheckCircleOutlined to LabelImportant because a check indicates that it is valid, where really we just want to display that it's enabled. We could leave it like this IMHO but doing the above would be more user-friendly.

I haven't done frontend in a very long time so please forgive any glaringly obvious violations of good practice and point them out to me so I can improve them.

[johnstcn]

We already generate the list of all valid experiments via typesgen, which means we have:

// From codersdk/deployment.go
export type Experiment = "auto-fill-parameters" | "example" | "shared-ports";
export const Experiments: Experiment[] = [
  "auto-fill-parameters",
  "example",
  "shared-ports",
];

Can we simply just use this to check if an experiment is valid or not?

[dannykopping]

Oh interesting! I didn't know about that list...
It seems stale though? auto-fill-parameters is not part of codersdk.ExperimentsAll. Perhaps I'll add a linter for this and move over to just using that list as the source of truth.

[johnstcn]

Oh interesting! I didn't know about that list... It seems stale though? auto-fill-parameters is not part of codersdk.ExperimentsAll. Perhaps I'll add a linter for this and move over to just using that list as the source of truth.

I think that may be due to auto-fill-parameters not being something we want to include as a "safe" experiment.

[johnstcn]

LGTM, but would probably also wait for someone from @fe to review.
Also note: when you make changes, you need to go into Chromatic to accept the new baseline.

[Parkreiner]

Accidentally published my reviews early – not quite done yet

[Parkreiner]

Had a couple of recommendations, but nothing worth blocking over.

I haven't worked as much with the E2E tests, but if you need help getting that to pass, I'm happy to pair on that

[Kira-Pilot]

@Parkreiner already gave a thorough review so I don't have too much to add. I approved your storybooks and the new UI looks nice! @mtojek might be able to help you out with that E2E test; it was added recently here.

[dannykopping]

@Parkreiner thanks for the detailed review! I've made your suggested changes plus a couple others.
Would you mind having one last look before I smash that like merge button?

[Parkreiner]

Had one last suggestion, but this looks good!