refactor: Move all HTTP routes to top-level struct #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be used for streaming logs, checking status, and other operations related to workspace and project history.
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 64.62% 69.05% +4.42%
==========================================
Files 57 100 +43
Lines 636 4317 +3681
Branches 68 68
==========================================
+ Hits 411 2981 +2570
- Misses 213 1074 +861
- Partials 12 262 +250
Continue to review full report at Codecov.
|
Nesting all structs behind their respective structures is leaky, and promotes naming conflicts between handlers. Our HTTP routes cannot have conflicts, so neither should function naming.
bryphe-coder
reviewed
Feb 1, 2022
| @@ -22,5 +22,6 @@ | |||
| "cmd": "make gen" | |||
| } | |||
| ] | |||
| } | |||
| }, | |||
| "cSpell.words": ["coderd", "coderdtest", "codersdk", "httpmw", "oneof", "stretchr", "xerrors"] | |||
There was a problem hiding this comment.
Thanks for adding these!
bryphe-coder
reviewed
Feb 1, 2022
|
|
||
| // WorkspaceHistory is an at-point representation of a workspace state. | ||
| // Iterate on before/after to determine a chronological history. | ||
| type WorkspaceHistory struct { |
There was a problem hiding this comment.
Thanks for splitting out the project/workspace history
bryphe-coder
reviewed
Feb 1, 2022
| Database: options.Database, | ||
| Pubsub: options.Pubsub, | ||
| } |
There was a problem hiding this comment.
I guess these were all essentially the same anyway - good call factoring to api
bryphe-coder
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nesting all structs behind their respective structures
is leaky, and promotes naming conflicts between handlers.
Our HTTP routes cannot have conflicts, so neither should
function naming.