chore(docs): add note regarding vcredist for embedded postgres #13020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Apr 22, 2024
|
There's this package: https://github.com/noneymous/go-redistributable-checker |
|
@johnstcn seems like we could also just implement this ourselves super easily instead of using a library. I think that's more helpful than including it in the docs. |
To clarify, you are proposing that we detect the absence of the VC++ redist libraries if using embedded postgres on windows, and log a message? |
|
I'm going to go ahead and merge this; will address Kyle's suggestion in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #13010
Adds a note regarding vcredist. Some Windows cloud images do not ship with this pre-installed.