refactor(site): reorganize template schedule settings form #13031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Looks really good! Mainly had a suggestion about tidying up the UI a bit more:
https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=662698f790e6752a83fb903a
I agree with your suggestions but I think it is out of the scope of this issue so I created an issue to track this improvement #13050. I plan to work on it on the "free" week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #12617
Demo
Screen.Recording.2024-04-22.at.10.04.27.mov
Autostop
Autostart
Dormancy
