Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add k8s terraform link to k8s installation docs #13040

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

doodzik
Copy link
Contributor

@doodzik doodzik commented Apr 23, 2024

Hello from Georgian again.

I've set up a GKE cluster for Coder with Terraform. The setup would have been much less work if I had known Terraform scripts were available. I copied the link from the Coder README pointing to your Terraform scripts and added it to the k8s installation guide. This will make it much easier to discover for someone who wants to install Coder on k8s.

As a side note, the link to the Terraform repo points to a user unaffiliated with Coder. This is a security risk because you don't control that repo. To fix this issue in the longer term, I would suggest creating a repo with Terraform scripts in your Coder organization.

\cc @ericpaulsen

@cdr-bot cdr-bot bot added the community Pull Requests created by the community. label Apr 23, 2024
@doodzik doodzik changed the title add k8s terraform link to k8s installation docs chore(docs): add k8s terraform link to k8s installation docs Apr 23, 2024
Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! @doodzik

@ericpaulsen
Copy link
Member

@doodzik can you run make fmt and push a new commit?

@kylecarbs kylecarbs merged commit 8b6227d into coder:main Apr 24, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Pull Requests created by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants