Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): add script to promote mainline to stable #13054

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Apr 23, 2024

Fixes #12459

Example dry-run:

Screenshot 2024-04-23 at 21 16 55

Example dry-run for non-latest version:

Screenshot 2024-04-23 at 21 17 52

Note: This PR does not yet update docs to reflect the promoted version. This will be part of #12465.

@mafredri mafredri force-pushed the mafredri/feat-add-promote-mainline-to-stable branch from 3013aeb to 3fa197b Compare April 23, 2024 18:00
@mafredri mafredri force-pushed the mafredri/feat-add-promote-mainline-to-stable branch 2 times, most recently from 02aac99 to 0e2e866 Compare April 23, 2024 18:16
@mafredri mafredri marked this pull request as ready for review April 23, 2024 18:19
@matifali
Copy link
Collaborator

Do we plan to automate this table, too?

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean script 👍

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes, LGTM

PerPage: perPage,
})
if err != nil {
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest wrapping this error or adding a log line before it showing what the current action is

if err != nil {
return err
}
logger.Info(ctx, "selected version promoted to stable")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a link to the release in the output for convenience?

body: `## Changelog

> [!NOTE]
> This is a mainline Coder release. We advise enterprise customers without a staging environment to install our [latest stable release](https://github.com/coder/coder/releases/latest) while we refine this version. Learn more about our [Release Schedule](https://coder.com/docs/v2/latest/install/releases).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be illustrative / more complete to add a test which shows that multiple lines subsequent to [!NOTE] prefixed with > are removed; we'll likely amend this note in the future.

@matifali
Copy link
Collaborator

Should these PRs be chore as it's not a user facing feature? It would end up as features in our changelog.

@mafredri
Copy link
Member Author

Should these PRs be chore as it's not a user facing feature? It would end up as features in our changelog.

That’s fair. I’ll change them.

@mafredri mafredri changed the title feat(scripts): add script to promote mainline to stable chore(scripts): add script to promote mainline to stable Apr 24, 2024
@mafredri
Copy link
Member Author

Do we plan to automate this table, too?

Not that I’m aware, it’s not mentioned in #12465.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mafredri mafredri force-pushed the mafredri/feat-add-promote-mainline-to-stable branch from 654add1 to 6898381 Compare April 24, 2024 14:24
Copy link
Member Author

mafredri commented Apr 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mafredri and the rest of your teammates on Graphite Graphite

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

// Example:
//
// > ## Stable (since April 23, 2024)
func addStableSince(date time.Time, body string) string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@mafredri mafredri merged commit c933c75 into main Apr 24, 2024
29 of 46 checks passed
@mafredri mafredri deleted the mafredri/feat-add-promote-mainline-to-stable branch April 24, 2024 19:59
Copy link
Member Author

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable Releases: Create new release script for promoting mainline to stable
5 participants