Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coderd): provisionerdserver: downgrade heartbeat failure log to Warn instead of Error #13061

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Apr 24, 2024

Addresses a test flake seen here: https://github.com/coder/coder/actions/runs/8812759745/job/24189086692#step:5:441

Does not address the underlying race condition that would require some plumbing modifications.

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp 👍

@johnstcn johnstcn merged commit a518047 into main Apr 24, 2024
32 checks passed
@johnstcn johnstcn deleted the cj/provisionerdserver-heartbeat-log-error branch April 24, 2024 08:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants