chore: dynamically determine gitlab external auth defaults #13102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static defaults work for github cloud, but not self hosted. Self hosted setups will now have sane defaults if omitted.
Emyrk
force-pushed
the
stevenmasley/dynamic_gitlab
branch
from
c744c90
to
0b15643
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static defaults work for github cloud, but not self hosted. Self hosted setups will now have sane defaults if omitted.
Closes #8293
Our docs do specify to include all values. This is just a safeguard against some mis-configuration. We do this for all other self hosted types, gitlab is just a special case where the same codersdk type is used for self hosted and cloud offering.