Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs for sharing ports #13136

Merged
merged 6 commits into from
May 3, 2024
Merged

chore: add docs for sharing ports #13136

merged 6 commits into from
May 3, 2024

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented May 3, 2024

After taking a look at our existing documentation, it made the most sense (to me personally) to add what we have drafted to the existing Port Forwarding docs. I know this page is very long, but I think this page should probably be looked at holistically in a separate effort to re-organize this docs page.

@stirby I left a few redundant images out and moved things around slightly, feel free to dive into this and make suggestions or changes as you see fit directly to the PR if you'd like.

Todos:

  • update any old screenshots to match new ones

@f0ssel f0ssel requested review from stirby and bpmct May 3, 2024 14:11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition

Copy link
Collaborator

@stirby stirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor copy changes and promoted all the new headers to allow "Configure maximum port sharing level" to render the enterprise label.

Before:
Screenshot 2024-05-03 at 10 43 24 AM

After:
Screenshot 2024-05-03 at 10 55 23 AM

@f0ssel f0ssel merged commit a3c23ed into main May 3, 2024
23 checks passed
@f0ssel f0ssel deleted the f0ssel/ps-docs branch May 3, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants