Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create broker for negotiating connections #14

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Conversation

kylecarbs
Copy link
Member

WebRTC require an exchange of encryption keys and network hops to connect. This package pipes the exchange over gRPC. This will be used in all connecting clients and agents.

WebRTC require an exchange of encryption keys and network hops to connect. This package pipes the exchange over gRPC. This will be used in all connecting clients and agents.
@kylecarbs kylecarbs self-assigned this Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #14 (2e511ba) into main (7c260f8) will increase coverage by 3.22%.
The diff coverage is 76.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   67.90%   71.13%   +3.22%     
==========================================
  Files          15       17       +2     
  Lines         888     1112     +224     
==========================================
+ Hits          603      791     +188     
- Misses        224      251      +27     
- Partials       61       70       +9     
Flag Coverage Δ
macos-latest 62.55% <74.10%> (+5.38%) ⬆️
ubuntu-latest 69.60% <74.10%> (+2.59%) ⬆️
windows-latest 61.20% <76.33%> (+5.25%) ⬆️
Impacted Files Coverage Δ
peer/conn.go 73.35% <71.42%> (+3.80%) ⬆️
peerbroker/dial.go 72.72% <72.72%> (ø)
peerbroker/listen.go 79.06% <79.06%> (ø)
peer/channel.go 87.42% <0.00%> (+3.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c260f8...2e511ba. Read the comment docs.

@@ -1,2 +1,3 @@
# Generated files
peerbroker/proto/*.go linguist-generated=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this to generated files 👍

@@ -113,6 +113,18 @@ jobs:
with:
go-version: "^1.17"

- uses: actions/cache@v2
with:
# Go mod cache, Linux build cache, Mac build cache, Windows build cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - I'll need this for yarn soon too.

)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we have goleak set up from the get-go 🎉

peerbroker/listen.go Outdated Show resolved Hide resolved
Co-authored-by: Bryan <bryan@coder.com>
@kylecarbs kylecarbs merged commit 53cfa8a into main Jan 11, 2022
@kylecarbs kylecarbs deleted the peerbroker branch January 11, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants