Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add parameter querying to the API #143

Merged
merged 6 commits into from
Feb 4, 2022
Merged

feat: Add parameter querying to the API #143

merged 6 commits into from
Feb 4, 2022

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs self-assigned this Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #143 (168a161) into main (75468fa) will decrease coverage by 0.51%.
The diff coverage is 54.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   66.99%   66.48%   -0.52%     
==========================================
  Files         103      104       +1     
  Lines        5129     5221      +92     
  Branches       68       68              
==========================================
+ Hits         3436     3471      +35     
- Misses       1381     1426      +45     
- Partials      312      324      +12     
Flag Coverage Δ
unittest-go-macos-latest 63.86% <54.34%> (-0.48%) ⬇️
unittest-go-ubuntu-latest 65.79% <50.00%> (-0.40%) ⬇️
unittest-go-windows-latest 63.35% <54.34%> (-0.59%) ⬇️
unittest-js 64.21% <ø> (ø)
Impacted Files Coverage Δ
coderd/parameters.go 45.45% <45.45%> (ø)
codersdk/projects.go 64.13% <45.45%> (-5.87%) ⬇️
coderd/coderd.go 93.33% <100.00%> (+0.37%) ⬆️
coderd/projects.go 67.22% <100.00%> (+3.33%) ⬆️
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
peer/conn.go 76.66% <0.00%> (-3.08%) ⬇️
provisionerd/provisionerd.go 68.94% <0.00%> (-0.74%) ⬇️
peer/channel.go 87.19% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75468fa...168a161. Read the comment docs.

@kylecarbs kylecarbs merged commit c3bae67 into main Feb 4, 2022
@kylecarbs kylecarbs deleted the parameters branch February 4, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants