Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add README parsing to template versions #1500

Merged
merged 4 commits into from
May 17, 2022
Merged

feat: add README parsing to template versions #1500

merged 4 commits into from
May 17, 2022

Conversation

coadler
Copy link
Member

@coadler coadler commented May 17, 2022 •
edited

Resolves: #1492

image

@coadler coadler self-assigned this May 17, 2022
@coadler coadler force-pushed the colin/template-version-description branch 2 times, most recently from 95198b9 to 61d3729 Compare May 17, 2022 00:42
@coadler coadler requested a review from a team as a code owner May 17, 2022 00:42
@coadler coadler requested a review from kylecarbs May 17, 2022 00:42
kylecarbs
kylecarbs approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor naming things, but LGTM!

provisionerd/provisionerd.go Show resolved Hide resolved
provisionerd/provisionerd.go Show resolved Hide resolved
provisionerd/provisionerd.go Outdated Show resolved Hide resolved
provisionerd/provisionerd.go Outdated Show resolved Hide resolved
codersdk/templateversions.go Outdated Show resolved Hide resolved
@coadler coadler force-pushed the colin/template-version-description branch from b834d0b to 759b362 Compare May 17, 2022 19:18
@coadler coadler merged commit 98ccd0e into main May 17, 2022
@coadler coadler deleted the colin/template-version-description branch May 17, 2022 20:00
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@coadler @kylecarbs
feat: add README parsing to template versions (#1500)
15964c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@greyscaled greyscaled greyscaled approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add README parsing to template versions
3 participants
@coadler @kylecarbs @greyscaled