Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example: update docker-local to use host-gateway #1507

Merged
merged 3 commits into from
May 17, 2022

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 17, 2022

This PR attempts to reduce the friction to getting a workspace up and running in docker when running Coder via docker-compose using the example docker-local template:

  • docker-compose.yaml: pass through docker socket and set CODER_ACCESS_URL env
  • examples/docker-local: add host.docker.internal to containers

See: #1345

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smooth!

Not necessarily in this PR, but I think we still want to document the setup steps?

cd /path/to/coder/repo
docker-compose up -d
coder login http://localhost:7080 # Create first user
coder templates create -d ./examples/docker-local
coder create dev

We could try to make some of them part of the compose file, perhaps it'd also be nicer to docker-compose run coder login ... to avoid having to install the binary.

docker-compose.yaml Outdated Show resolved Hide resolved
…CONNECTION_URL

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
CODER_ADDRESS: "0.0.0.0:7080"
CODER_ACCESS_URL: "http://host.docker.internal:7080"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be set inside the specific template!

Override the "url" field of the "coder" provider!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@Emyrk
Copy link
Member

Emyrk commented May 17, 2022

I didn't realize we had a docker-compose. Sweet!

@johnstcn johnstcn enabled auto-merge (squash) May 17, 2022 14:39
@johnstcn johnstcn merged commit 75dc8f5 into main May 17, 2022
@johnstcn johnstcn deleted the cj/gh-1345/example-docker-host-gateway branch May 17, 2022 14:40
@bpmct
Copy link
Member

bpmct commented May 17, 2022

Very smooth!

Not necessarily in this PR, but I think we still want to document the setup steps?

cd /path/to/coder/repo
docker-compose up -d
coder login http://localhost:7080 # Create first user
coder templates create -d ./examples/docker-local
coder create dev

We could try to make some of them part of the compose file, perhaps it'd also be nicer to docker-compose run coder login ... to avoid having to install the binary.

@mafredri Yep, I'd like to document it, but I'd consider #1528 another blocker from this being a clean workflow.

I'm not really sure what the best way to document the coder login thing is... 🤔

kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* fix: example: update docker-local to use host-gateway
* docker-compose.yaml: Add POSTGRES_ environment variables to CODER_PG_CONNECTION_URL

Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants