Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make dev #1527

Merged
merged 2 commits into from
May 17, 2022
Merged

chore: add make dev #1527

merged 2 commits into from
May 17, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented May 17, 2022

I saw a slack thread where devs did not know to run ./develop.sh and I believe this is because it's not reflected anywhere in our Makefile. Since the script "requires" you to run make build before anyways, I figured this was a good candidate for a make dev command.

I moved develop.sh to scripts/develop.sh since it makes more sense if we start using the make command.

I'm OK with vetoing this if we don't like it.

Example:

➜  coder git:(f0ssel/make-dev) ✗ make dev
go run scripts/apitypings/main.go > site/src/api/typesGenerated.ts
cd site && yarn run format:types
yarn run v1.22.19
$ prettier --write 'src/api/typesGenerated.ts'
src/api/typesGenerated.ts 501ms
Done in 1.41s.
./scripts/yarn_install.sh
+ yarn install 
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
...

@f0ssel f0ssel requested review from kylecarbs, Emyrk and a team May 17, 2022 16:28
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd post in a few of our major development slack channels just to give everyone a heads up the script is moving.

Nice one.

@f0ssel
Copy link
Contributor Author

f0ssel commented May 17, 2022

Yeah this would change the primary dev command and remove the previous script location so everyone will need to be aware of the change before merge.

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be in the readme.

We just say coder server --dev in the readme, but without doing this you don't have the UI.

@f0ssel
Copy link
Contributor Author

f0ssel commented May 17, 2022

@Emyrk The mention of coder server --dev is for usage, not development. I've updated the contribution docs with this change though.

@f0ssel f0ssel merged commit 495c87b into main May 17, 2022
@f0ssel f0ssel deleted the f0ssel/make-dev branch May 17, 2022 18:12
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants