Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update pion/webrtc to fix ICE negotiation race #153

Merged
merged 6 commits into from
Feb 3, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Feb 3, 2022

Run 1: ✅
Run 2: ✅
Run 3: ✅
Run 4: ✅
Run 5: ✅ peer passed, but CI failed because of a provisionerd bug fixed in another PR.
Run 6: ✅
Run 7: ✅

It's pretty safe to say this fixes the race!

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #153 (d03f508) into main (e75bde4) will increase coverage by 2.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   64.92%   67.69%   +2.76%     
==========================================
  Files          55      101      +46     
  Lines         633     5101    +4468     
  Branches       68       68              
==========================================
+ Hits          411     3453    +3042     
- Misses        210     1340    +1130     
- Partials       12      308     +296     
Flag Coverage Δ
unittest-go-macos-latest 64.57% <92.59%> (?)
unittest-go-ubuntu-latest 66.04% <66.66%> (?)
unittest-go-windows-latest 63.84% <88.88%> (?)
unittest-js 64.92% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 79.74% <100.00%> (ø)
httpmw/organizationparam.go 69.81% <0.00%> (ø)
cryptorand/strings.go 80.64% <0.00%> (ø)
coderd/workspacehistory.go 55.13% <0.00%> (ø)
coderd/cmd/root.go 86.11% <0.00%> (ø)
codersdk/projects.go 70.00% <0.00%> (ø)
codersdk/provisioners.go 0.00% <0.00%> (ø)
database/time.go 0.00% <0.00%> (ø)
database/postgres/postgres.go 70.73% <0.00%> (ø)
coderd/projecthistory.go 65.21% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75bde4...d03f508. Read the comment docs.

@kylecarbs kylecarbs force-pushed the kylecarbs/investigate/pion-logging branch 2 times, most recently from e19111c to 4086811 Compare February 3, 2022 19:37
@kylecarbs kylecarbs changed the title experiment: Add trace logging for WebRTC offer and answer fix: Use forked pion/webrtc to fix ICE negotiation race Feb 3, 2022
@kylecarbs kylecarbs force-pushed the kylecarbs/investigate/pion-logging branch from 426556e to f898cf6 Compare February 3, 2022 19:42
@kylecarbs kylecarbs marked this pull request as ready for review February 3, 2022 19:42
@kylecarbs kylecarbs self-assigned this Feb 3, 2022
@kylecarbs kylecarbs force-pushed the kylecarbs/investigate/pion-logging branch from f898cf6 to f0c0db5 Compare February 3, 2022 19:51
@kylecarbs kylecarbs changed the title fix: Use forked pion/webrtc to fix ICE negotiation race fix: Update pion/webrtc to fix ICE negotiation race Feb 3, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) February 3, 2022 19:56
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So stoked to see all that green! ✅

@kylecarbs kylecarbs force-pushed the kylecarbs/investigate/pion-logging branch from 4d1a3bf to 46260a8 Compare February 3, 2022 21:41
@kylecarbs kylecarbs force-pushed the kylecarbs/investigate/pion-logging branch from 20115d6 to d03f508 Compare February 3, 2022 21:59
@kylecarbs kylecarbs merged commit fb020a5 into main Feb 3, 2022
@kylecarbs kylecarbs deleted the kylecarbs/investigate/pion-logging branch February 3, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants