bug: using NavLink for menus #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #955
greyscaled
reviewed
May 17, 2022
greyscaled
approved these changes
May 17, 2022
|
Hey @Kira-Pilot , can you update your branch to latest |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* bug: using NavLink for menus resolves #955 * lets fix our story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #955
Small fix where we make
pathrequired and useNavLinkto navigate.I wanted to clean up active styles a bit and get rid of the
onClickhandler with activeClassName and isActive but sadly these props aren't in the latest release of react router. There's already an open ticket in their repo that I'm subscribed to so we can clean things up in the future.