feat: Add echo provisioner #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the cdr-basic provisioner type with "echo". It reads binary data from the directory and returns the responses in order. This is used to test project and workspace job logic.
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 66.38% 65.34% -1.05%
==========================================
Files 105 106 +1
Lines 5501 5580 +79
Branches 68 68
==========================================
- Hits 3652 3646 -6
- Misses 1508 1578 +70
- Partials 341 356 +15
Continue to review full report at Codecov.
|
bryphe-coder
reviewed
Feb 4, 2022
Comment on lines
+39
to
+42
| // The echo provisioner serves as a dummy provisioner primarily | ||
| // used for testing. It echos responses from JSON files in the | ||
| // format %d.protobuf. It's used for testing. | ||
| type echo struct { |
There was a problem hiding this comment.
Neat! It's actually really nice to have an example of the most-simple-possible provisioner, just to understand how all the pieces fit together
bryphe-coder
reviewed
Feb 4, 2022
| projectHistory := setupProjectHistory(t, server.Client, user, project, map[string]string{ | ||
| "main.tf": `resource "null_resource" "test" {}`, | ||
| }) | ||
| data, err := echo.Tar(echo.ParseComplete, []*proto.Provision_Response{{ |
bryphe-coder
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the cdr-basic provisioner type with
"echo". It reads binary data from the directory
and returns the responses in order.
This is used to test project and workspace job logic.
I'm going to fix up tests that consume this to increase coverage in a subsequent PR!