chore: Add (skipped) ptytest test that hangs on Intel Mac (and Windows)
#1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was prompted by macOS test failures in #1591, and investigation using my macOS. The issue was narrowed down to not reading from If we can confirm that the tests are correct, we could merge this in as skipped tests and open up a new issue to track the progress. |
|
What's the status of this PR? |
mafredri
force-pushed
the
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
branch
from
ad76f64
to
7692c5d
Compare
mafredri
force-pushed
the
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
branch
from
21bcca7
to
034cfa6
Compare
mafredri
changed the title
ptytest on Intel Mac (and Windows)
mafredri
changed the title
ptytest on Intel Mac (and Windows)ptytest on Intel Mac (and Windows)
mafredri
force-pushed
the
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
branch
from
e7fad00
to
487f338
Compare
Emyrk
approved these changes
Jun 7, 2022
mafredri
changed the title
ptytest on Intel Mac (and Windows)ptytest test that hangs on Intel Mac (and Windows)
mafredri
deleted the
mafredri/draft-ptytest-hangs-on-macos-when-output-is-not-consumed
branch
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
…ows) (#1629) Co-authored-by: Steven Masley <stevenmasley@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR adds a test that breaks
ptytestwith unconsumed output on Intel Macs.This is left open to inform / opportunity to investigate.
To reproduce:
go test ./pty/ptytest -v -run=TestPtytest/Do_not_hang -timeout=5sHere is the trace: trace.txt
// @coder/backend @Emyrk