Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename ProjectHistory to ProjectVersion #165

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Conversation

kylecarbs
Copy link
Member

Version more accurately represents version storage. This
forks from the WorkspaceHistory name, but I think it's
easier to understand Workspace history.

Version more accurately represents version storage. This
forks from the WorkspaceHistory name, but I think it's
easier to understand Workspace history.
@kylecarbs kylecarbs self-assigned this Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #165 (7c46342) into main (2b41ac6) will not change coverage.
The diff coverage is 77.92%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   65.37%   65.37%           
=======================================
  Files         106      106           
  Lines        5580     5580           
  Branches       68       68           
=======================================
  Hits         3648     3648           
  Misses       1576     1576           
  Partials      356      356           
Flag Coverage Δ
unittest-go-macos-latest 62.62% <77.92%> (+0.02%) ⬆️
unittest-go-ubuntu-latest 64.45% <77.92%> (+0.24%) ⬆️
unittest-go-windows-latest 62.42% <77.92%> (+0.10%) ⬆️
unittest-js 64.21% <ø> (ø)
Impacted Files Coverage Δ
coderd/provisionerdaemons.go 47.21% <56.25%> (ø)
codersdk/workspaces.go 48.36% <60.00%> (ø)
coderd/workspacehistory.go 53.72% <69.23%> (ø)
coderd/projectparameter/projectparameter.go 67.44% <75.00%> (ø)
httpmw/projectversionparam.go 76.47% <76.47%> (ø)
codersdk/projects.go 63.10% <82.35%> (ø)
coderd/projectversion.go 61.14% <88.57%> (ø)
coderd/coderd.go 93.50% <100.00%> (ø)
provisionerd/provisionerd.go 67.95% <100.00%> (ø)
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b41ac6...7c46342. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up 👍

@kylecarbs kylecarbs merged commit f19770b into main Feb 5, 2022
@kylecarbs kylecarbs deleted the projectversion branch February 5, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants