Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add <CodeBlock /> component #168

Merged
merged 9 commits into from
Feb 7, 2022

Conversation

bryphe-coder
Copy link
Contributor

This ports over a component from v1 that is needed for the v2 workspace page, and adds theme colors for it:

Screen Shot 2022-02-05 at 10 39 28 AM

Component in storybook:
image

By bringing in these components ahead of time - it'll make the workspaces page PR smaller.

@bryphe-coder bryphe-coder self-assigned this Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #168 (23ac375) into main (f19770b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   65.44%   65.42%   -0.03%     
==========================================
  Files         106      107       +1     
  Lines        5580     5588       +8     
  Branches       68       68              
==========================================
+ Hits         3652     3656       +4     
- Misses       1572     1576       +4     
  Partials      356      356              
Flag Coverage Δ
unittest-go-macos-latest 62.51% <ø> (-0.22%) ⬇️
unittest-go-ubuntu-latest 63.92% <ø> (-0.43%) ⬇️
unittest-go-windows-latest 61.77% <ø> (-0.55%) ⬇️
unittest-js 64.66% <100.00%> (+0.44%) ⬆️
Impacted Files Coverage Δ
site/theme/palettes.ts 100.00% <ø> (ø)
site/components/CodeBlock/index.tsx 100.00% <100.00%> (ø)
peerbroker/dial.go 76.19% <0.00%> (-4.77%) ⬇️
peer/conn.go 77.17% <0.00%> (-0.77%) ⬇️
coderd/provisionerdaemons.go 47.80% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19770b...23ac375. Read the comment docs.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice

@bryphe-coder bryphe-coder merged commit e3089e9 into main Feb 7, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/add-codeblock-component branch February 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants