ci: Replace DataDog CI with custom upload script #169
Conversation
kylecarbs
force-pushed
the
datadog
branch
2 times, most recently
from
876fcc6
to
c7f65c1
Compare
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 67.75% 67.57% -0.18%
==========================================
Files 107 107
Lines 5644 5650 +6
Branches 68 68
==========================================
- Hits 3824 3818 -6
- Misses 1463 1471 +8
- Partials 357 361 +4
Continue to review full report at Codecov.
|
kylecarbs
force-pushed
the
datadog
branch
2 times, most recently
from
6061196
to
92c2aba
Compare
This will reduce CI time by ~6 minutes across all of our runners. It's a bit janky, but I believe worth the slight maintainance burden.
kylecarbs
force-pushed
the
datadog
branch
5 times, most recently
from
6ab61f3
to
6117e87
Compare
| // It's built using node, and took ~3 minutes to install and | ||
| // run on our Windows runner, and ~1 minute on all others. |
There was a problem hiding this comment.
The built binary could probably be cached once it's built, too!
There was a problem hiding this comment.
I had it cache, but the Windows runner has such slow disk IO it made little difference 😥
| // The DataDog "cireport" API is not publicly documented, | ||
| // but implementation is available in their open-source CLI | ||
| // built for CI: https://github.com/DataDog/datadog-ci |
| provisionerJobID := uuid.New() | ||
| projectVersion, err = api.Database.InsertProjectVersion(r.Context(), database.InsertProjectVersionParams{ |
There was a problem hiding this comment.
non-blocking: It'd be nice to have the race fixes in a separate PR - just so the CI could be evaluated independently (or if we found there was a regression, we could pull it off w/o impacting the DataDog improvements)
There was a problem hiding this comment.
Entirely agree. Just fixed these in here to ensure my CI changes didn't break anything. I'm going to let it slide in this PR, because hopefully CI is reliable enough from this point forward that these types of things can't slip in.
| // The DataDog "cireport" API is not publicly documented, | ||
| // but implementation is available in their open-source CLI | ||
| // built for CI: https://github.com/DataDog/datadog-ci |
There was a problem hiding this comment.
thought: I wonder if utilities like this would be good open-source candidates for our org? We ourselves searched for a tool like this, and couldn't find it - so you had to build it!
I figure if this is around and someone else finds it, could be marketing for coder overall
There was a problem hiding this comment.
I do agree this is a great candidate for OSS!
This will reduce CI time by ~6 minutes across all of our runners. It's a bit janky, but I believe worth the slight maintenance burden.
Because this is quick now, we upload tests for PostgreSQL and fake database implementations.