refactor: Rename ProjectParameter to ProjectVersionParameter #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 65.54% 65.77% +0.22%
==========================================
Files 103 103
Lines 5294 5294
Branches 68 68
==========================================
+ Hits 3470 3482 +12
+ Misses 1495 1485 -10
+ Partials 329 327 -2
Continue to review full report at Codecov.
|
This was confusing with ParameterValue before. It still is a bit, but this should help distinguish scope.
kylecarbs
force-pushed
the
projectversionparam
branch
from
95b1365
to
1af0b50
Compare
bryphe-coder
reviewed
Feb 7, 2022
| @@ -40,11 +40,11 @@ func Compute(ctx context.Context, db database.Store, scope Scope) ([]Value, erro | |||
| compute := &compute{ | |||
| db: db, | |||
| computedParameterByName: map[string]Value{}, | |||
| projectVersionParametersByName: map[string]database.ProjectParameter{}, | |||
| projectVersionParametersByName: map[string]database.ProjectVersionParameter{}, | |||
There was a problem hiding this comment.
Thanks for updating this name - it does help clarify the scope for me
bryphe-coder
approved these changes
Feb 7, 2022
kylecarbs
force-pushed
the
projectversionparam
branch
from
d719383
to
2df0927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was confusing with ParameterValue before. It still is a bit,
but this should help distinguish scope.